Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest simulator by not specifying the OS version #7061

Closed
wants to merge 1 commit into from
Closed

Use latest simulator by not specifying the OS version #7061

wants to merge 1 commit into from

Conversation

jsierles
Copy link
Contributor

Appetize asked for this so they can better support us, since they will usually have more simulators available for the latest versions.

@facebook-github-bot
Copy link
Contributor

By analyzing the blame information on this pull request, we identified @janicduplessis and @vjeux to be potential reviewers.

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Apr 19, 2016
@mkonicek
Copy link
Contributor

@facebook-github-bot shipit

@facebook-github-bot
Copy link
Contributor

Thanks for importing. If you are an FB employee go to Phabricator to review.

@ghost ghost closed this in 1c6d815 Apr 19, 2016
@jsierles
Copy link
Contributor Author

What needs to happen for this to show up on the website? Appetize is asking.

@janicduplessis
Copy link
Contributor

Since the website is versioned now it won't show up by default until 0.26 is released, it should show up if you choose the 'master' version of the docs though.

@jsierles
Copy link
Contributor Author

I see - is there a way to make an exception?

@janicduplessis
Copy link
Contributor

I think it is if we cherry pick the commit in the release branches.

cc @bestander

@bestander
Copy link
Contributor

We can do this, sure.

bestander pushed a commit that referenced this pull request Apr 22, 2016
@jsierles @bestander
Use latest simulator by not specifying the OS version
87b30ee 
Summary:Appetize asked for this so they can better support us, since they will usually have more simulators available for the latest versions.
Closes #7061

Differential Revision: D3196110

Pulled By: mkonicek

fb-gh-sync-id: 2406ab6e1ee352f0148957e851d7f483a2182f90
fbshipit-source-id: 2406ab6e1ee352f0148957e851d7f483a2182f90
@bestander
Copy link
Contributor

cherry-picked, this is the build that will deploy the website https://circleci.com/gh/facebook/react-native/5682

@janicduplessis
Copy link
Contributor

@bestander you should probably do it for 0.25-rc too since this won't be in until 0.26

@bestander bestander mentioned this pull request Apr 22, 2016
Closed
1 task
@bestander
Copy link
Contributor

Added link to the tracking issue

@jsierles
Copy link
Contributor Author

Thanks!

@vjeux
Copy link
Contributor

vjeux commented Apr 22, 2016

Would be nice to automate this process. Maybe a command

@facebook-github-bot ship-website-live

Or something

@bestander
Copy link
Contributor

Maybe, although I think it is an exception when we want to release
something to current stable website.
Cherry-picking took me 2 minutes.

On Fri, Apr 22, 2016 at 10:24 PM, Christopher Chedeau <
notifications@github.com> wrote:

Would be nice to automate this process. Maybe a command

@facebook-github-bot https://github.com/facebook-github-bot
ship-website-live

Or something

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#7061 (comment)

grabbou pushed a commit that referenced this pull request May 4, 2016
@jsierles @grabbou
Use latest simulator by not specifying the OS version
0289363 
Summary:Appetize asked for this so they can better support us, since they will usually have more simulators available for the latest versions.
Closes #7061

Differential Revision: D3196110

Pulled By: mkonicek

fb-gh-sync-id: 2406ab6e1ee352f0148957e851d7f483a2182f90
fbshipit-source-id: 2406ab6e1ee352f0148957e851d7f483a2182f90
ptmt pushed a commit to ptmt/react-native that referenced this pull request May 9, 2016
@jsierles @ptmt
Use latest simulator by not specifying the OS version
1300f05 
Summary:Appetize asked for this so they can better support us, since they will usually have more simulators available for the latest versions.
Closes facebook#7061

Differential Revision: D3196110

Pulled By: mkonicek

fb-gh-sync-id: 2406ab6e1ee352f0148957e851d7f483a2182f90
fbshipit-source-id: 2406ab6e1ee352f0148957e851d7f483a2182f90
zebulgar pushed a commit to nightingale/react-native that referenced this pull request Jun 18, 2016
@jsierles @zebulgar
Use latest simulator by not specifying the OS version
95a0444 
Summary:Appetize asked for this so they can better support us, since they will usually have more simulators available for the latest versions.
Closes facebook#7061

Differential Revision: D3196110

Pulled By: mkonicek

fb-gh-sync-id: 2406ab6e1ee352f0148957e851d7f483a2182f90
fbshipit-source-id: 2406ab6e1ee352f0148957e851d7f483a2182f90
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jsierles @facebook-github-bot @mkonicek @janicduplessis @bestander @vjeux