[Native-Animated] Support for Animated.add #6641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @kmagiera to be a potential reviewer. |
facebook-github-bot
added
GH Review: review-needed
CLA Signed
| __getNativeConfig(): any { | ||
| return { | ||
| type: 'addition', | ||
| input: [this._a.__getNativeTag(), this._b.__getNativeTag()], |
|
Thanks @facebook-github-bot, great job on finding potential reviewers! In addition I'd like to nominate @astreet if that's ok with you |
|
@kmagiera updated the pull request. |
|
@kmagiera updated the pull request. |
| __getNativeConfig(): any { | ||
| return { | ||
| type: 'addition', | ||
| input: [this._a.__getNativeTag(), this._b.__getNativeTag()], |
kmagiera
force-pushed
the
nativeanim_add
branch
from
3abee72 to
aca1065
Compare
|
@kmagiera updated the pull request. |
| @@ -19,6 +19,10 @@ | |||
|
|
|||
| /*package*/ double mValue = Double.NaN; | |||
|
|
|||
| ValueAnimatedNode() { | |||
| // empty constructor that can be used by subclasses | |||
|
Can you remove the 'add unit tests' PR from this PR too? |
|
looks good otherwise |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
This change adds suport native animated support for Animated.add. Animated.add lets you declare node that outputs a sum of it input nodes. **Test Plan** Play with the following playground app: https://gist.github.com/39de37faf07480fcd7d1 Run JS tests: `npm test Libraries/Animated/src/__tests__/AnimatedNative-test.js` Run java tests: `buck test ReactAndroid/src/test/java/com/facebook/react/animated`
kmagiera
force-pushed
the
nativeanim_add
branch
from
aca1065 to
60015f6
Compare
|
@kmagiera updated the pull request. |
|
Alright. I've fixed package/protected attributes and rebase on top of master so that this PR has only one commit now. @facebook-github-bot shipit |
facebook-github-bot
added
GH Review: accepted
and removed
GH Review: review-needed
labels
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
1 similar comment
|
Thanks for importing. If you are an FB employee go to Phabricator to review. |
ghost
closed this
in
ptmt
pushed a commit
to ptmt/react-native
that referenced
this pull request
May 9, 2016
Summary:This change adds suport native animated support for Animated.add. Animated.add lets you declare node that outputs a sum of it input nodes. **Test Plan** Play with the following playground app: https://gist.github.com/39de37faf07480fcd7d1 Run JS tests: `npm test Libraries/Animated/src/__tests__/AnimatedNative-test.js` Run java tests: `buck test ReactAndroid/src/test/java/com/facebook/react/animated` Closes facebook#6641 Differential Revision: D3195963 fb-gh-sync-id: bb1e1a36821a0e071ad0e7d0fa99ce0d6b088b0a fbshipit-source-id: bb1e1a36821a0e071ad0e7d0fa99ce0d6b088b0a
zebulgar
pushed a commit
to nightingale/react-native
that referenced
this pull request
Jun 18, 2016
Summary:This change adds suport native animated support for Animated.add. Animated.add lets you declare node that outputs a sum of it input nodes. **Test Plan** Play with the following playground app: https://gist.github.com/39de37faf07480fcd7d1 Run JS tests: `npm test Libraries/Animated/src/__tests__/AnimatedNative-test.js` Run java tests: `buck test ReactAndroid/src/test/java/com/facebook/react/animated` Closes facebook#6641 Differential Revision: D3195963 fb-gh-sync-id: bb1e1a36821a0e071ad0e7d0fa99ce0d6b088b0a fbshipit-source-id: bb1e1a36821a0e071ad0e7d0fa99ce0d6b088b0a
bubblesunyum
pushed a commit
to iodine/react-native
that referenced
this pull request
Aug 23, 2016
Summary:This change adds suport native animated support for Animated.add. Animated.add lets you declare node that outputs a sum of it input nodes. **Test Plan** Play with the following playground app: https://gist.github.com/39de37faf07480fcd7d1 Run JS tests: `npm test Libraries/Animated/src/__tests__/AnimatedNative-test.js` Run java tests: `buck test ReactAndroid/src/test/java/com/facebook/react/animated` Closes facebook#6641 Differential Revision: D3195963 fb-gh-sync-id: bb1e1a36821a0e071ad0e7d0fa99ce0d6b088b0a fbshipit-source-id: bb1e1a36821a0e071ad0e7d0fa99ce0d6b088b0a
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds suport native animated support for Animated.add.
Animated.add lets you declare node that outputs a sum of it input nodes.
Test Plan
Play with the following playground app: https://gist.github.com/39de37faf07480fcd7d1
Run JS tests:
npm test Libraries/Animated/src/__tests__/AnimatedNative-test.jsRun java tests:
buck test ReactAndroid/src/test/java/com/facebook/react/animated