Add global flow types to eslint globals #5585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a subset of the global flow types from the fbjs eslint config to remove the no-undef warnings for flow types
facebook-github-bot
added
GH Review: review-needed
CLA Signed
|
cc @satya164 |
|
Nice thanks! @facebook-github-bot shipit |
|
Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/965937440120672/int_phab to review. |
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "rules": { | |||
| "no-alert": 0 | |||
There was a problem hiding this comment.
FYI, you can do
/* eslint no-alert: 0 */
at the top of the file in order to disable it for a specific file
There was a problem hiding this comment.
@vjeux Yes, I figured we could allow it for every file in examples instead of adding the rule per file since it was already used in a bunch of different files and it's pretty common to want to show a simple alert in examples.
ghost
closed this
in
doostin
pushed a commit
to doostin/react-native
that referenced
this pull request
Feb 1, 2016
Summary: Added a subset of the global flow types from the fbjs eslint config to remove the no-undef errors for flow types as well as a few missing browser globals that were used in the codebase. I also added a .eslintrc file to Examples to allow using alert there without warnings. Closes facebook#5585 Reviewed By: svcscm Differential Revision: D2872016 Pulled By: vjeux fb-gh-sync-id: f9b1b511289425393074b7237049dec38ea407b6
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a subset of the global flow types from the fbjs eslint config to remove the no-undef errors for flow types as well as a few missing browser globals that were used in the codebase.
I also added a .eslintrc file to Examples to allow using alert there without warnings.