Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for iOS displaying a RedBox for LogBox handled errors #32641

Closed
wants to merge 1 commit into from
Closed

Fix for iOS displaying a RedBox for LogBox handled errors #32641

wants to merge 1 commit into from

Conversation

liamjones
Copy link
Contributor

@liamjones liamjones commented Nov 22, 2021

Summary

Fix for iOS displaying a RedBox for LogBox handled errors, this has been happening since RN 0.65 (in 64.2 and earlier, if it was handled by LogBox then it wouldn't trigger RedBox)

Fixes #32106

Changelog

[iOS] [Fixed] - Stop RedBox from appearing for LogBox handled errors

Test Plan

Manually tested. Seems to fix things (and RedBox still displays for things like 'Could not connect to development server') but I would appreciate @RSNara or someone else who is more familiar with the code to confirm that the original switch was a mistake and not something deliberately changed.

Looks to be a mistake made during commit 938bfed - `updateErrorMessage` got changed for a `showErrorMessage`
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Nov 22, 2021
@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Nov 22, 2021
@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 19bca22
Branch: main

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 8,478,031 +0
android hermes armeabi-v7a 7,777,241 +0
android hermes x86 8,946,819 +0
android hermes x86_64 8,890,868 +0
android jsc arm64-v8a 9,792,798 +0
android jsc armeabi-v7a 8,753,225 +0
android jsc x86 9,741,535 +0
android jsc x86_64 10,342,348 +0

Base commit: 19bca22
Branch: main

@christophemenager
Copy link

I tried it locally on my project and it worked 🆗

@facebook-github-bot
Copy link
Contributor

@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @liamjones in 9d2df5b.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Needs: React Native Team Attention Platform: iOS iOS applications. Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.65] [iOS] Redbox displayed as well as LogBox
6 participants