fix: prevent activity recreation on theme change #26413
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
facebook-github-bot
added
p: Callstack
There was a problem hiding this comment.
@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @Esemesek in 83a16b1. When will my fix make it into a release? | Upcoming Releases |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| @@ -13,7 +13,7 @@ | |||
| <activity | |||
| android:name=".MainActivity" | |||
| android:label="@string/app_name" | |||
| android:configChanges="keyboard|keyboardHidden|orientation|screenSize" | |||
Importing change made to React Native example apps in facebook/react-native#26413
Importing change made to React Native example apps in facebook/react-native#26413
Importing change made to React Native example apps in facebook/react-native#26413
Importing change made to React Native example apps in facebook/react-native#26413
Importing change made to React Native example apps in facebook/react-native#26413
Importing change made to React Native example apps in facebook/react-native#26413
Summary
On Android 10 whole activity is recreated when the user changes system theme. We should prevent it by adding
uiModeinandroid:configChangeskey in the default template.Changelog
[Android] [Fixed] - Android 10: Prevent activity recreation on theme change
Test Plan
NOOP