add docker test to circle-ci #24375
Closed
add docker test to circle-ci #24375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
Thanks for taking care of this! |
facebook-github-bot
approved these changes
Apr 10, 2019
There was a problem hiding this comment.
@hramos is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
This pull request was successfully merged by @gengjiawen in 6a3e799. When will my fix make it into a release? | Upcoming Releases |
dsyang
pushed a commit
to dsyang/react-native
that referenced
this pull request
Apr 12, 2019
Summary: add docker related test to ci (only build part), prevent future regression like facebook#24360 [General] [Added] - add docker related test to ci Pull Request resolved: facebook#24375 Differential Revision: D14865224 Pulled By: hramos fbshipit-source-id: 8fbc2935b0479c362a0fb68022a1157ff68b0325
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add docker related test to ci (only build part), prevent future regression like #24360
Changelog
[General] [Added] - add docker related test to ci
Test Plan
pas current ci