Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Fix Jest deprecation warning #22626

Closed
wants to merge 2 commits into from
Closed

WIP Fix Jest deprecation warning #22626

wants to merge 2 commits into from

Conversation

CodingItWrong
Copy link
Contributor

@CodingItWrong CodingItWrong commented Dec 13, 2018

Please do not merge: troubleshooting the Detox E2E tests from #22621 in progress

Fixes a deprecation warning from Jest: 'Option "setupTestFrameworkScriptFile" was replaced by configuration "setupFilesAfterEnv", which supports multiple paths.'

By fixing this warnings, we increase contributors' confidence that things are working correctly, and draw attention to any warnings that they should pay attention to, if and when they arise.

Test Plan:

Run:

detox build -c ios.sim.debug
detox test -c ios.sim.debug

You should not see any warnings in the console.

Changelog:

[General] [Fixed] - Fix Jest deprecation warning

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests This PR adds or edits a test case. labels Dec 13, 2018
@CodingItWrong CodingItWrong changed the title Fix Jest deprecation warning WIP Fix Jest deprecation warning Dec 13, 2018
@pull-bot
Copy link

Warnings
⚠️

🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.

Generated by 🚫 dangerJS

@CodingItWrong
Copy link
Contributor Author

closing in favor of #22621

@CodingItWrong CodingItWrong deleted the fix-e2e-warnings-2 branch December 14, 2018 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Tests This PR adds or edits a test case.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants