-
Notifications
You must be signed in to change notification settings - Fork 24.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix matricesDiffer ignoring first value of matrix
Summary: Changelog: [internal] # Problem Implementation of `matricesDiffer` was ignoring first element in the matrix, therefore two matrixes that were different were actually evaluated as same and React didn't pass value to native. # Solution Take first element in the matrix into account when comparing matrices. Reviewed By: cpojer Differential Revision: D20117210 fbshipit-source-id: 84c3b4e580da44bda4fc8bd8669318282ae9aa32
- Loading branch information
1 parent
6beee03
commit d33ead3
Showing
2 changed files
with
46 additions
and
0 deletions.
There are no files selected for viewing
45 changes: 45 additions & 0 deletions
45
Libraries/Utilities/differ/__tests__/matricesDiffer-test.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
/** | ||
* Copyright (c) Facebook, Inc. and its affiliates. | ||
* | ||
* This source code is licensed under the MIT license found in the | ||
* LICENSE file in the root directory of this source tree. | ||
* | ||
* @format | ||
* @emails oncall+react_native | ||
*/ | ||
|
||
'use strict'; | ||
|
||
const matricesDiffer = require('../matricesDiffer'); | ||
|
||
describe('matricesDiffer', function() { | ||
it('diffs matrices with single element', () => { | ||
var x = [1]; | ||
var y = [2]; | ||
expect(matricesDiffer(x, y)).toBe(true); | ||
|
||
x = [1]; | ||
y = [1]; | ||
expect(matricesDiffer(x, y)).toBe(false); | ||
}); | ||
|
||
it('diffs matrices with different number of elements', () => { | ||
var x = [1, 1, 1, 1]; | ||
var y = [1, 1, 1, 2]; | ||
expect(matricesDiffer(x, y)).toBe(true); | ||
}); | ||
|
||
it('diffs matrices with 16 elements', () => { | ||
var x = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]; | ||
var y = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]; | ||
expect(matricesDiffer(x, y)).toBe(false); | ||
|
||
x = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]; | ||
y = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 2, 1]; | ||
expect(matricesDiffer(x, y)).toBe(true); | ||
|
||
x = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]; | ||
y = [2, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1]; | ||
expect(matricesDiffer(x, y)).toBe(true); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters