Skip to content

Commit

Permalink
review changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Daksh Bhardwaj committed Sep 9, 2022
1 parent 13b5e10 commit ad116e0
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 15 deletions.
4 changes: 1 addition & 3 deletions Libraries/Components/Pressable/Pressable.js
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,7 @@ function Pressable(props: Props, forwardedRef): React.Node {
...android_rippleConfig?.viewProps,
accessible: accessible !== false,
accessibilityViewIsModal:
restProps['aria-modal'] !== null
? restProps['aria-modal']
: restProps.accessibilityViewIsModal,
restProps['aria-modal'] ?? restProps.accessibilityViewIsModal,
accessibilityLiveRegion,
accessibilityState: _accessibilityState,
focusable: focusable !== false,
Expand Down
4 changes: 1 addition & 3 deletions Libraries/Components/Touchable/TouchableBounce.js
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,7 @@ class TouchableBounce extends React.Component<Props, State> {
: this.props.importantForAccessibility
}
accessibilityViewIsModal={
this.props['aria-modal'] !== null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal
this.props['aria-modal'] ?? this.props.accessibilityViewIsModal
}
accessibilityElementsHidden={
this.props['aria-hidden'] ?? this.props.accessibilityElementsHidden
Expand Down
4 changes: 1 addition & 3 deletions Libraries/Components/Touchable/TouchableHighlight.js
Original file line number Diff line number Diff line change
Expand Up @@ -311,9 +311,7 @@ class TouchableHighlight extends React.Component<Props, State> {
: this.props.importantForAccessibility
}
accessibilityViewIsModal={
this.props['aria-modal'] !== null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal
this.props['aria-modal'] ?? this.props.accessibilityViewIsModal
}
accessibilityLiveRegion={accessibilityLiveRegion}
accessibilityElementsHidden={
Expand Down
4 changes: 1 addition & 3 deletions Libraries/Components/Touchable/TouchableNativeFeedback.js
Original file line number Diff line number Diff line change
Expand Up @@ -302,9 +302,7 @@ class TouchableNativeFeedback extends React.Component<Props, State> {
? 'no-hide-descendants'
: this.props.importantForAccessibility,
accessibilityViewIsModal:
this.props['aria-modal'] !== null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal,
this.props['aria-modal'] ?? this.props.accessibilityViewIsModal,
accessibilityLiveRegion: accessibilityLiveRegion,
accessibilityElementsHidden:
this.props['aria-hidden'] ?? this.props.accessibilityElementsHidden,
Expand Down
4 changes: 1 addition & 3 deletions Libraries/Components/Touchable/TouchableOpacity.js
Original file line number Diff line number Diff line change
Expand Up @@ -257,9 +257,7 @@ class TouchableOpacity extends React.Component<Props, State> {
: this.props.importantForAccessibility
}
accessibilityViewIsModal={
this.props['aria-modal'] !== null
? this.props['aria-modal']
: this.props.accessibilityViewIsModal
this.props['aria-modal'] ?? this.props.accessibilityViewIsModal
}
accessibilityLiveRegion={accessibilityLiveRegion}
accessibilityElementsHidden={
Expand Down

0 comments on commit ad116e0

Please sign in to comment.