Correct anchor height offset for Black Lives Matter banner #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for react-native ready! Built with commit 738360c https://deploy-preview-2109--react-native.netlify.app Changes to Thank you for your contributions. |
Simek
requested changes
Jul 28, 2020
There was a problem hiding this comment.
Hi @FLGMwt, thank you for the fix and the preview of the changes, that's great! 👍
Just a small request before the merge - can you move the code under the 'announcement banner' section in the header.css file - https://github.com/facebook/react-native-website/blob/master/website/static/css/header.css#L201 ?
It will help to revert all the changes in the future and ensures that no unneeded code will left.
FLGMwt
force-pushed
the
adjust-anchor-header-offset
branch
from
c4566ee to
738360c
Compare
|
👍 Done! Put it right after the header container heights since that seemed the most relevant. |
Simek
approved these changes
Jul 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Black Lives Matter call to action banner added a fixed 100px to the pre-content banner height. Docusaurus seems to have a built-in anchor style to handle this itself, so this just updates that -80 to -180. Mobile was off a bit differently but 160px looked alright there.
EDIT: mobile before and after: