Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove broken on-page sidebar from Running on Device page #2105

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Jul 27, 2020

Refs #2001

This PR replaces the Markdown headings with the HTML ones to prevent onPageNav (right sidebar) from populate on the Running on Device page.

All the changes has been backported to the 0.63 versioned docs to affect most of the website users.

Quote from my comment in the mentioned issue:

The problems described above are known issues caused by content switching tabs (platform and OS in this case). For the same reason the right sidebar has been disabled on the Environment Setup page.

Within the current docs platform restrictions (Docusaurus V1) it is not possible to fix this problem cleanly in our codebase (also the V1 development has been frozen a while ago in favor of V2). Unfortunately the only solution for now is to disable the onPageNav (the right sidebar) on this page.

@rachelnabors Of course it's not an ideal solution, but at least it's not the first exception. I hope that with V2 in the future solving such problem will be a way easier.

@Simek Simek requested a review from rachelnabors July 27, 2020 15:15
@react-native-bot
Copy link

Deploy preview for react-native ready!

Built with commit 3f9059a

https://deploy-preview-2105--react-native.netlify.app

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@rachelnabors rachelnabors merged commit 9873772 into facebook:master Jul 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants