Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add percentage dimensions section to the Height and Width page #2101

Merged
merged 2 commits into from
Aug 1, 2020

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Jul 26, 2020

Fixes #2071

Refs #2079


This PR adds the Percentage Dimensions section with a Snack example and short description (which for certain can be updated and phrased better 😉) to the Height and Width page.

I have also optimized a bit the readability of the other examples on that page.

Preview

Annotation 2020-07-26 204848

@react-native-bot
Copy link

react-native-bot commented Jul 26, 2020

Deploy preview for react-native ready!

Built with commit ae48b89

https://deploy-preview-2101--react-native.netlify.app

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@react-native-bot
Copy link

Deploy preview for react-native ready!

Built with commit 1b778e4

https://deploy-preview-2101--react-native.netlify.app

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

Copy link
Contributor

@rachelnabors rachelnabors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sm_thanks

Thanks for expanding on this!!

@Simek Simek merged commit 1308d3d into facebook:master Aug 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update height and width documentation to reflect percentage support
4 participants