Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update StatusBar example and docs #2059

Merged
merged 2 commits into from
Jul 24, 2020

Conversation

Simek
Copy link
Collaborator

@Simek Simek commented Jul 17, 2020

This PR updates the StatusBar component page and introduces following changes:

  • rewritten example:
    • simplify code
    • include transition toggler on iOS devices
    • use SafeAreaView instead of container styles adjustments
  • platform labels
  • missing default values added
  • missing types added

Also the small CSS adjustments were required because the page contains first occurrence of platform label inside the table and the small fix was required for the labels in the right sidebar.

Preview

Annotation 2020-07-17 105951

@react-native-bot
Copy link

Deploy preview for react-native ready!

Built with commit 242af83

https://deploy-preview-2059--react-native.netlify.app

Changes to docs/ are reflected in the next "master" version.

Thank you for your contributions.

How to ContributeDocumentation Sources

@rachelnabors
Copy link
Contributor

Thank you so much for updating this component, @Simek! Merging :)

@rachelnabors rachelnabors merged commit 73043e8 into facebook:master Jul 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants