Wrong logic on write-translation.js

[gimdongwoo]

Motivation

I found wrong logic on lib/write-translation.js

const path = require('path');
...
if (fs.existsSync(path)) {  // wrong code. `path` is NodeJs module
  currentTranslations = JSON.parse(
    fs.readFileSync(CWD + '/i18n/en.json', 'utf8')
  );
}

As a result, currentTranslations is always empty.
Because, the contents of i18n/en.json are always lost.

It's correct code

if (fs.existsSync(CWD + '/i18n/en.json')) {
  currentTranslations = JSON.parse(
    fs.readFileSync(CWD + '/i18n/en.json', 'utf8')
  );
}

Have you read the Contributing Guidelines on pull requests?

Yes

Test Plan

Related PRs

[docusaurus-bot]

Deploy preview for docusaurus-preview ready!

Built with commit bf80b33

https://deploy-preview-710--docusaurus-preview.netlify.com

[yangshun]

Great catch. Thanks!

[JoelMarcey]

We have had that piece of code since October 2017. Makes me wonder how translations actually have worked at all 😆 🤣

[endiliey]

Before this PR is merged, It always generate new i18en.json and is not allowing us to override english string from what #158 intend to do. currentTranslation is always lost

Actually this introduces bug #713

[JoelMarcey]

@endiliey Are you saying this fix introduces #713? Or that without this fix, #713 exists?

[endiliey]

without this fix #713 doesnt exist
With this fix introduces #713