Add open in browser functionality #643
Conversation
|
Deploy preview for docusaurus-preview ready! Built with commit a54800a |
There was a problem hiding this comment.
@yangshun Interesting. Does it just choose the default browser of the running system to open?
|
@JoelMarcey Yep it uses the user's default browser setting! Saves me a few seconds of typing each time I start the server. |
|
Got it. I wanted to play around this a bit before putting in an official release, that's why it will go in the next version. Hope that is cool. One more rebase? |
|
Yep totally ok! It's not that important to be in 1.0.15 as it's not a user-facing feature. Thanks! |
|
Great! Just one more rebase. Sorry. Just want to always be clean, even if I am pretty sure the merge would be fine 😄 |
|
Done! I think you are able to rebase the PR too. There's an "Update branch" button which I use to rebase other contributors' PRs before merging. Does that work? |
|
I guess you are right, I can just update the branch 😄 |
|
Thank you! 😍@JoelMarcey |
|
I love this PR 😍 |
Motivation
Improve developer experience
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
yarn startAlso tested with a running server, it opens in localhost:3001, which is correct.
Related PRs
NA