chore: upgrade prettier; rename prettier scripts as format #6010
+24
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Cena
added
the
pr: maintenance
|
✔️ [V2] 🔨 Explore the source changes: d648dc2 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/61a04be6f011b80007f32ed3 😎 Browse the preview: https://deploy-preview-6010--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-6010--docusaurus-2.netlify.app/ |
|
Size Change: -1 B (0%) Total Size: 892 kB ℹ️ View Unchanged
|
|
Thanks, LGTM 👍 |
|
Also agree on renaming to format as prettier is an implementation detail (similarly to the logger interface somehow, except it's not like there are a lot of good JS formatted libs apart prettier 😅 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Prettier v2.5 supports new TS syntax, which we will soon adopt after ts-eslint releases new version with support. (typescript-eslint/typescript-eslint#3950; this would likely be in quite a while)
In addition, all scripts named
prettierare renamed asformat, because this avoids name conflicts.yarn prettiershould invoke the localprettierexecutable rather than our custom script.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
CI