fix: allow ColorGenerator to parse colors with prefix #
#5669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ [V2] 🔨 Explore the source changes: ebbdf46 🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6160806b7a673b000778c112 😎 Browse the preview: https://deploy-preview-5669--docusaurus-2.netlify.app |
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://deploy-preview-5669--docusaurus-2.netlify.app/ |
lex111
added
the
pr: maintenance
lex111
approved these changes
Oct 9, 2021
|
@Andrewnt219 works fine, thanks! |
|
Hi @lex111, I'll be really happy if you also add "hacktoberfest-accepted" label to the PR 😄. |
|
It's not really necessary, this label is already added to the repository, so every PR counts in HF. |
|
@lex111, ah that's right. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #5665
Currently, the color generator at Styling Your File With Infima doesn't handle input string with the prefix
#. More than often, users copy colors from design apps, dev tools or config files with a prefix#in them.Therefore, I removed any leading
#soColorwon't throw when there is a prefix#.Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Inside preview, go to Guides > Styling and Layout > Styling Your File With Infima. Enter these values for Primary color:
ccc-> table should update with new colors.#abc-> table should update with new colors.##cba-> table should update with new colors.Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)