Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding scrollbar to header when it overflows #444

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

maazadeeb
Copy link
Contributor

@maazadeeb maazadeeb commented Feb 11, 2018

Motivation

Fixes #441

Test Plan

  1. Add many dummy entries into the siteConfig.js.
  2. Use the Chrome devtools' "Toggle Device Mode" to simulate various responsive sizes. Note: Just make sure you refresh the page once when you switch to mobile mode. This guarantees that the page is loaded in the simulated mobile mode and any old CSS effects from the desktop mode are not into play.

scroll_doc

cc @JoelMarcey

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@JoelMarcey
Copy link
Contributor

This is great @maaz93. Thanks so much!

Copy link
Contributor

@JoelMarcey JoelMarcey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@JoelMarcey JoelMarcey merged commit 5e39b2e into facebook:master Feb 12, 2018
@maazadeeb
Copy link
Contributor Author

Awesome! Will wait for the next release to update the Babel website.

JoelMarcey added a commit that referenced this pull request Feb 12, 2018
@JoelMarcey
Copy link
Contributor

@maaz93 Hi. I commented on #445 that I had to revert this :( It broke Algolia search. I am thinking we can only overflow when the header links are on their own row like in your original screenshot here? So we just need to put the overflow in the @media only place.

@maazadeeb
Copy link
Contributor Author

Oops. That's a bit weird. I put a overflow-x and there's a vertical scroll. I'll look at it. Can we re-open the issue?

@JoelMarcey
Copy link
Contributor

Issue is reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Signed Facebook CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants