Ignore and warn about unsupported header fields #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsupported header fields might mess up the creation of metadata.js (e.g.: next). Skip unknown header fields and log a warn about them.
|
Hey @aadsm sorry that your PR was left hanging for so long. This looks like a really useful feature. Could you rebase on master and update your PR? Would be very keen to merge this! 👍 |
|
@yangshun At one point I was thinking about a different design for this, but I have forgotten how I was going to handle it. And then I let it languish. Seeing how the "Squash and Merge" button is still enabled, it may not need a full rebase, just some prettier updates I think. |
JoelMarcey
approved these changes
Apr 12, 2018
|
I added support for |
yangshun
pushed a commit
that referenced
this pull request
Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsupported header fields might mess up the creation of metadata.js (e.g.: next).
Skip unknown header fields and log a warn about them.
I believe these are all the supported fields at the moment?