fix(v2): move anchor link to right of heading #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for docusaurus-2 ready! Built with commit 80089eb |
yangshun
approved these changes
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After changing the size of the header font in Infima, the anchor link of heading overlaps to it (and in the case of lower-level headings we can see that hash is too far from the heading).
Since hash link size is the same as its heading, obviously we need to calculate its own position for each heading. This is pretty time consuming using pure CSS. So I think a quick and easy fix for this behavior is to place the hash link on the right side of the headings (see test plan).
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Before (currently improper behavior):
After
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)