feat(v2): pluralize posts on tag's page #2263
Merged
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lex111
commented
Feb 1, 2020
packages/docusaurus-theme-classic/src/theme/BlogTagsPostsPage/index.js
Outdated
Show resolved
Hide resolved
|
Deploy preview for docusaurus-2 ready! Built with commit 52982ee |
yangshun
suggested changes
Feb 3, 2020
There was a problem hiding this comment.
I don't know if pluralize should be part of Docusaurus core utils. I get that we want to fix it for the blog page, but can we just add it to the blog plugin instead of Docusaurus core? I don't want to bloat up the core. The smaller API surface we have, the better for maintainability.
|
Hmm, yes, apparently I was mistaken with this decision, fixed ✔️ |
yangshun
approved these changes
Feb 3, 2020
|
Fixed, it seems to me time to rest 🤕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding basic feature to form plural word forms. This is of course a very simple util function, and when localization functionality appears, it needs to be improved, but at the moment it is doing its job perfectly
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan