refactor: remove react-dev-utils (CRA) dependency, internalize code
#10956
+467
−244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slorber
added
the
pr: maintenance
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
packages/docusaurus-bundler/src/legacy/formatWebpackMessages.js
Dismissed
Show dismissed
Hide dismissed
packages/docusaurus-bundler/src/legacy/formatWebpackMessages.js
Dismissed
Show dismissed
Hide dismissed
packages/docusaurus-bundler/src/legacy/formatWebpackMessages.js
Dismissed
Show dismissed
Hide dismissed
packages/docusaurus-bundler/src/legacy/formatWebpackMessages.js
Dismissed
Show dismissed
Hide dismissed
⚡️ Lighthouse report for the deploy preview of this PR
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
Size Change: +319 B (0%) Total Size: 11.1 MB ℹ️ View Unchanged
|
|
Size Change: +309 B (0%) Total Size: 11.6 MB ℹ️ View Unchanged
|
…onstructed from library input Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
Report too large to display inline |
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
packages/docusaurus/src/commands/utils/openBrowser/openBrowser.ts
Dismissed
Show dismissed
Hide dismissed
✅ [V2]
To edit notification comments on pull requests, go to your Netlify site configuration. |
slorber
added
the
pr: performance
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CRA is now deprecated, and its
react-dev-utilspackage too.https://react.dev/blog/2025/02/14/sunsetting-create-react-app
We only use a subset of that package but pull a large dependency tree because of it.
Let's remove the dependency, and copy/paste the legacy code into our project.
Fix #7289
I also refactored to TS and cleaned up some utils like
openBrowser()andprepareUrls(), removed useless code branches and transitive dependencies.Other others
evalSourceMapMiddlewareandformatWebpackMessagesare quite complex, untested, and harder to convert to TS so I left them as-is in JS.Benchmark -
node_moduleinstall sizeBefore: 242M
After: 237M
Test Plan
CI + various local tests
Unfortunately, this is not well-covered by unit tests and not easy to write some.
Test links
https://deploy-preview-10956--docusaurus-2.netlify.app/