Allow to override resetMocks and resetModules Jest configuration?

[jpetitcolas]

I am wondering if you would be opened to allow overriding the resetMocks and resetModules options from Jest configuration? Currently, when trying to update them directly in the package.json such as:

{
  "jest": {
    "resetMocks": true
  }
}

I got a message telling me it is not configurable:

Out of the box, Create React App only supports overriding these Jest options:

  • collectCoverageFrom
  • coverageReporters
  • coverageThreshold
  • snapshotSerializers.

As an absent minded developer, I will always forget to restore a mock one day or another. And this parameter would save (the future) me a lot of time. Is there any particular reason to restrict these two options? Or is it just a lack waiting for a PR? :)

Related Jest documentation: https://facebook.github.io/jest/docs/en/configuration.html#resetmocks-boolean

[GAumala]

overriding resetMocks would be a really nice feature. I wish jest would let the user configure it via a command line argument, though.

[eliw00d]

+1 for overriding config and/or as CLI argument.

[gaearon]

Sure, that sounds good.

[adamtowerz]

Can this issue be expanded to cover other jest configurations like "setupFiles" so it can support mocking libraries like jest-localstorage-mock?

[gaearon]

Does setupFiles let you do something you can't put in src/setupTests.js (that's automatically executed before tests)?

[adamtowerz]

It doesn't provide any functionality you can't put in src/setupTests.js, but it feels like a better solution for supporting libraries that act as Jest plugins than to write a new file to import these plugins. It is also the solution Jest natively supports, so if it is possible to just pass on the configuration to Jest I don't see a reason not to support the option.

[gaearon]

but it feels like a better solution for supporting libraries that act as Jest plugins than to write a new file to import these plugins

I see your point but I feel that since it's perfectly possible to use the global conventional file, and we already support it, this doesn't really add value.

resetMocks and resetModules still sounds good though.

[garmeeh]

PR #3802 opened to try add this feature.

[gaearon]

#3802