Add template support (#7716)

* Add template support

* Update templates version check

* Update TypeScript template README

azure-pipelines.yml

@@ -1,78 +1,79 @@
-#
-# Azure Pipelines configuration for building and testing create-react-app on Linux, Windows, and macOS.
-#
-
-trigger:
-  - master
-
-variables:
-  CI: true
-  # Overrides the Yarn and NPM cache directories so they are on the same drive as the source. This helps improve build performance on Windows hosted agents.
-  YARN_CACHE_FOLDER: $(Build.SourcesDirectory)/../yarn-cache
-  NPM_CONFIG_CACHE: $(Build.SourcesDirectory)/../npm-cache
-  # Sets TEMP to be on the same drive as the cloned source on Windows. This avoids test scripts that "cd" into a directory under TEMP from failing because this directory is on a different drive from the current directory.
-  VSTS_OVERWRITE_TEMP: True
-  # Override Verdaccio package to use. This is temporary and is needed to avoid socket timeouts on hosted Windows agent (on Azure). This also changes Verdaccio to return a 503 (service unavailable) instead of a 404 (not found) when the connection to the uplink timesout.
-  VERDACCIO_PACKAGE: https://github.com/willsmythe/verdaccio/releases/download/create-react-app/verdaccio-4.0.0-alpha.8.tgz
-
-# ******************************************************************************
-# Simple test suite
-# ******************************************************************************
-jobs:
-  - template: azure-pipelines-test-job.yml
-    parameters:
-      name: Simple
-      testScript: tasks/e2e-simple.sh
-
-  # ******************************************************************************
-  # Installs test suite
-  # ******************************************************************************
-  - template: azure-pipelines-test-job.yml
-    parameters:
-      name: Installs
-      testScript: tasks/e2e-installs.sh
-
-  # ******************************************************************************
-  # Kitchensink test suite
-  # ******************************************************************************
-  - template: azure-pipelines-test-job.yml
-    parameters:
-      name: Kitchensink
-      testScript: tasks/e2e-kitchensink.sh
-
-  # ******************************************************************************
-  # Kitchensink Eject test suite
-  # ******************************************************************************
-  - template: azure-pipelines-test-job.yml
-    parameters:
-      name: KitchensinkEject
-      testScript: tasks/e2e-kitchensink-eject.sh
-
-  # ******************************************************************************
-  # Behavior test suite
-  # ******************************************************************************
-  - template: azure-pipelines-test-job.yml
-    parameters:
-      name: Behavior
-      testScript: tasks/e2e-behavior.sh
-      configurations:
-        LinuxNode8: { vmImage: 'ubuntu-16.04', nodeVersion: 8.x }
-        LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
-        # WindowsNode8:  { vmImage: 'vs2017-win2016', nodeVersion: 8.x  }
-        # WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
-        MacNode8: { vmImage: 'macOS-10.13', nodeVersion: 8.x }
-        MacNode10: { vmImage: 'macOS-10.13', nodeVersion: 10.x }
-
-  # ******************************************************************************
-  # Old Node test suite
-  # ******************************************************************************
-  - job: OldNode
-    pool:
-      vmImage: ubuntu-16.04
-    steps:
-      - task: NodeTool@0
-        inputs:
-          versionSpec: 6.x
-        displayName: 'Install Node.js 6.x'
-      - bash: tasks/e2e-old-node.sh
-        displayName: 'Run tests'
+#
+# Azure Pipelines configuration for building and testing create-react-app on Linux, Windows, and macOS.
+#
+
+trigger:
+  - master
+
+variables:
+  CI: true
+  # Overrides the Yarn and NPM cache directories so they are on the same drive as the source. This helps improve build performance on Windows hosted agents.
+  YARN_CACHE_FOLDER: $(Build.SourcesDirectory)/../yarn-cache
+  NPM_CONFIG_CACHE: $(Build.SourcesDirectory)/../npm-cache
+  # Sets TEMP to be on the same drive as the cloned source on Windows. This avoids test scripts that "cd" into a directory under TEMP from failing because this directory is on a different drive from the current directory.
+  VSTS_OVERWRITE_TEMP: True
+  # Override Verdaccio package to use. This is temporary and is needed to avoid socket timeouts on hosted Windows agent (on Azure). This also changes Verdaccio to return a 503 (service unavailable) instead of a 404 (not found) when the connection to the uplink timesout.
+  VERDACCIO_PACKAGE: https://github.com/willsmythe/verdaccio/releases/download/create-react-app/verdaccio-4.0.0-alpha.8.tgz
+  CRA_INTERNAL_TEST: true
+
+# ******************************************************************************
+# Simple test suite
+# ******************************************************************************
+jobs:
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: Simple
+      testScript: tasks/e2e-simple.sh
+
+  # ******************************************************************************
+  # Installs test suite
+  # ******************************************************************************
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: Installs
+      testScript: tasks/e2e-installs.sh
+
+  # ******************************************************************************
+  # Kitchensink test suite
+  # ******************************************************************************
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: Kitchensink
+      testScript: tasks/e2e-kitchensink.sh
+
+  # ******************************************************************************
+  # Kitchensink Eject test suite
+  # ******************************************************************************
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: KitchensinkEject
+      testScript: tasks/e2e-kitchensink-eject.sh
+
+  # ******************************************************************************
+  # Behavior test suite
+  # ******************************************************************************
+  - template: azure-pipelines-test-job.yml
+    parameters:
+      name: Behavior
+      testScript: tasks/e2e-behavior.sh
+      configurations:
+        LinuxNode8: { vmImage: 'ubuntu-16.04', nodeVersion: 8.x }
+        LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
+        # WindowsNode8:  { vmImage: 'vs2017-win2016', nodeVersion: 8.x  }
+        # WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
+        MacNode8: { vmImage: 'macOS-10.13', nodeVersion: 8.x }
+        MacNode10: { vmImage: 'macOS-10.13', nodeVersion: 10.x }
+
+  # ******************************************************************************
+  # Old Node test suite
+  # ******************************************************************************
+  - job: OldNode
+    pool:
+      vmImage: ubuntu-16.04
+    steps:
+      - task: NodeTool@0
+        inputs:
+          versionSpec: 6.x
+        displayName: 'Install Node.js 6.x'
+      - bash: tasks/e2e-old-node.sh
+        displayName: 'Run tests'

docusaurus/docs/adding-typescript.md

@@ -12,14 +12,16 @@ title: Adding TypeScript
 To start a new Create React App project with [TypeScript](https://www.typescriptlang.org/), you can run:
 
 ```sh
-npx create-react-app my-app --typescript
+npx create-react-app my-app --template typescript
 
 # or
 
-yarn create react-app my-app --typescript
+yarn create react-app my-app --template typescript
 ```
 
 > If you've previously installed `create-react-app` globally via `npm install -g create-react-app`, we recommend you uninstall the package using `npm uninstall -g create-react-app` to ensure that `npx` always uses the latest version.
+>
+> Global installs of `create-react-app` are no longer supported.
 
 To add [TypeScript](https://www.typescriptlang.org/) to a Create React App project, first install it:
 
@@ -49,5 +51,4 @@ If your project is not created with TypeScript enabled, npx may be using a cache
 
 If you are currently using [create-react-app-typescript](https://github.com/wmonk/create-react-app-typescript/), see [this blog post](https://vincenttunru.com/migrate-create-react-app-typescript-to-create-react-app/) for instructions on how to migrate to Create React App.
 
-
 Constant enums and namespaces are not supported, you can learn about the constraints of [using Babel with TypeScript here](https://babeljs.io/docs/en/babel-plugin-transform-typescript#caveats).

docusaurus/docs/advanced-configuration.md

@@ -11,7 +11,7 @@ You can adjust various development and production settings by setting environmen
 | :---------------------- | :---------: | :--------: | :----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
 | BROWSER                 |   ✅ Used   | 🚫 Ignored | By default, Create React App will open the default system browser, favoring Chrome on macOS. Specify a [browser](https://github.com/sindresorhus/open#app) to override this behavior, or set it to `none` to disable it completely. If you need to customize the way the browser is launched, you can specify a node script instead. Any arguments passed to `npm start` will also be passed to this script, and the url where your app is served will be the last argument. Your script's file name must have the `.js` extension.                                                                                                                                      |
 | BROWSER_ARGS            |   ✅ Used   | 🚫 Ignored | When the `BROWSER` environment variable is specified, any arguments that you set to this environment variable will be passed to the browser instance. Multiple arguments are supported as a space separated list. By default, no arguments are passed through to browsers.                                                                                                                                                                                                                                                                                                                                                                                               |
-| HOST                    |   ✅ Used   | 🚫 Ignored | By default, the development web server binds to all hostnames on the device (`localhost`, LAN network address, etc.). You may use this variable to specify a different host.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |
+| HOST                    |   ✅ Used   | 🚫 Ignored | By default, the development web server binds to all hostnames on the device (`localhost`, LAN network address, etc.). You may use this variable to specify a different host.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                             |
 | PORT                    |   ✅ Used   | 🚫 Ignored | By default, the development web server will attempt to listen on port 3000 or prompt you to attempt the next available port. You may use this variable to specify a different port.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                      |
 | HTTPS                   |   ✅ Used   | 🚫 Ignored | When set to `true`, Create React App will run the development server in `https` mode.                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                    |
 | PUBLIC_URL              | 🚫 Ignored  |  ✅ Used   | Create React App assumes your application is hosted at the serving web server's root or a subpath as specified in [`package.json` (`homepage`)](deployment#building-for-relative-paths). Normally, Create React App ignores the hostname. You may use this variable to force assets to be referenced verbatim to the url you provide (hostname included). This may be particularly useful when using a CDN to host your application.                                                                                                                                                                                                                                     |

docusaurus/docs/getting-started.md

@@ -62,13 +62,33 @@ yarn create react-app my-app
 
 _`yarn create` is available in Yarn 0.25+_
 
-### Creating a TypeScript app
+### Selecting a template
 
-Follow our [Adding TypeScript](adding-typescript.md) documentation to create a TypeScript app.
+You can now optionally start a new app from a template by appending `--template [template-name]` to the creation command.
+
+If you don't select a template, we'll create your project with our base template.
+
+Templates are always named in the format `cra-template-[template-name]`, however you only need to provide the `[template-name]` to the creation command.
+
+```sh
+npx create-react-app my-app --template [template-name]
+```
+
+> You can find a a list of available templates by searching for ["cra-template-\*"](https://www.npmjs.com/search?q=cra-template-*) on npm.
+
+#### Creating a TypeScript app
+
+You can start a new TypeScript app using templates. To use our provided TypeScript template, append `--template typescript` to the creation command.
+
+```sh
+npx create-react-app my-app --template typescript
+```
+
+If you already have a project and would like to add TypeScript, see our [Adding TypeScript](adding-typescript.md) documentation.
 
 ### Selecting a package manager
 
-When you create a new app, the CLI will use [Yarn](https://yarnpkg.com/) to install dependencies (when available). If you have Yarn installed, but would prefer to use npm, you can append --use-npm to the creation command. For example:
+When you create a new app, the CLI will use [Yarn](https://yarnpkg.com/) to install dependencies (when available). If you have Yarn installed, but would prefer to use npm, you can append `--use-npm` to the creation command. For example:
 
 ```sh
 npx create-react-app my-app --use-npm

packages/cra-template-typescript/README.md

@@ -0,0 +1,20 @@
+# cra-template-typescript
+
+This is the official TypeScript template for [Create React App](https://github.com/facebook/create-react-app).
+
+To use this template, add `--template typescript` when creating a new app.
+
+For example:
+
+```sh
+npx create-react-app my-app --template typescript
+
+# or
+
+yarn create react-app my-app --template typescript
+```
+
+For more information, please refer to:
+
+- [Getting Started](https://create-react-app.dev/docs/getting-started) – How to create a new app.
+- [User Guide](https://create-react-app.dev) – How to develop apps bootstrapped with Create React App.

packages/cra-template-typescript/package.json

@@ -0,0 +1,28 @@
+{
+  "name": "cra-template-typescript",
+  "version": "1.0.0",
+  "keywords": [
+    "react",
+    "create-react-app",
+    "template",
+    "typescript"
+  ],
+  "description": "The base TypeScript template for Create React App.",
+  "main": "template.json",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/facebook/create-react-app.git",
+    "directory": "packages/cra-template-typescript"
+  },
+  "license": "MIT",
+  "engines": {
+    "node": ">=8.10"
+  },
+  "bugs": {
+    "url": "https://github.com/facebook/create-react-app/issues"
+  },
+  "files": [
+    "template",
+    "template.json"
+  ]
+}

packages/cra-template-typescript/template.json

@@ -0,0 +1,9 @@
+{
+  "dependencies": {
+    "@types/node": "^12.0.0",
+    "@types/react": "^16.9.0",
+    "@types/react-dom": "^16.9.0",
+    "@types/jest": "^24.0.0",
+    "typescript": "^3.6.0"
+  }
+}

packages/cra-template/README.md

@@ -0,0 +1,10 @@
+# cra-template
+
+This is the official base template for [Create React App](https://github.com/facebook/create-react-app).
+
+If you don't specify a template (for example, `--template typescript`), this template will be used by default.
+
+For more information, please refer to:
+
+- [Getting Started](https://create-react-app.dev/docs/getting-started) – How to create a new app.
+- [User Guide](https://create-react-app.dev) – How to develop apps bootstrapped with Create React App.

packages/cra-template/package.json

@@ -0,0 +1,27 @@
+{
+  "name": "cra-template",
+  "version": "1.0.0",
+  "keywords": [
+    "react",
+    "create-react-app",
+    "template"
+  ],
+  "description": "The base template for Create React App.",
+  "main": "template.json",
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/facebook/create-react-app.git",
+    "directory": "packages/cra-template"
+  },
+  "license": "MIT",
+  "engines": {
+    "node": ">=8"
+  },
+  "bugs": {
+    "url": "https://github.com/facebook/create-react-app/issues"
+  },
+  "files": [
+    "template",
+    "template.json"
+  ]
+}

packages/cra-template/template.json

@@ -0,0 +1,3 @@
+{
+    "dependencies": {}
+}

packages/cra-template/template/src/index.css

@@ -0,0 +1,13 @@
+body {
+  margin: 0;
+  font-family: -apple-system, BlinkMacSystemFont, 'Segoe UI', 'Roboto', 'Oxygen',
+    'Ubuntu', 'Cantarell', 'Fira Sans', 'Droid Sans', 'Helvetica Neue',
+    sans-serif;
+  -webkit-font-smoothing: antialiased;
+  -moz-osx-font-smoothing: grayscale;
+}
+
+code {
+  font-family: source-code-pro, Menlo, Monaco, Consolas, 'Courier New',
+    monospace;
+}