Some fb_postfix fixups for Debian/Ubuntu #287
Open
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a few of our defaults that weren't correct on Debian/Ubuntu. I suspect these are the root of what @PatrickDale was running into in facebook#225. I didn't see it because my local cookbooks overwrote these three variables. However, I'm rolling this out to more Debian systems and bumped into it, so fixing it. Signed-off-by: Phil Dibowitz <phil@ipom.com>
|
cc @mrichins / @ericnorris for the next time upstream is pulled in. This is a similar change that we have in our fork, but it would probably be better to use this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few of our defaults that weren't correct on Debian/Ubuntu. I
suspect these are the root of what @PatrickDale was running into in #225.
I didn't see it because my local cookbooks overwrote these three
variables.
However, I'm rolling this out to more Debian systems and bumped into it,
so fixing it.
Signed-off-by: Phil Dibowitz phil@ipom.com