Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

append $basedir to all output directory paths #98

Merged
merged 5 commits into from
Feb 27, 2015
Merged

append $basedir to all output directory paths #98

merged 5 commits into from
Feb 27, 2015

Conversation

jgangemi
Copy link
Collaborator

fix for issue #97

rhuss and others added 4 commits February 14, 2015 20:08
@rhuss
Prepare for next release
ec94c5b
@rhuss
[maven-release-plugin] prepare release v0.11.1
c8e4574
@rhuss
[maven-release-plugin] prepare for next development iteration
b45b8c2
@jgangemi
issue 97
e38d6e3 
- append $basedir to all output directories if the path is not absolute

Signed-off-by: Jae Gangemi <jgangemi@gmail.com>
@kuhnroyal
Copy link
Contributor

Noticed this as well today, I only fixed it for the source directory before.
LGTM

@jgangemi
Copy link
Collaborator Author

yeah - i actually just realized something else is potentially wrong w/ this - if you build two images, the data from one will override the data from the other in the output dir, so you loose the ability to see what was done for previous images.

i'm going to add an additional enhancement to this that will include the image name as part of the output directory path.

@jgangemi
- append image name to target output dirs so they are unique
aad854a 
Signed-off-by: Jae Gangemi <jgangemi@gmail.com>
@jgangemi
Copy link
Collaborator Author

to prevent annoying merge conflicts this should be pulled after #105

@jgangemi jgangemi changed the title append $basedir to all output diretory paths append $basedir to all output directory paths Feb 19, 2015
@kuhnroyal
Copy link
Contributor

Yea nice, ran into the problem you described last night. Lucky for me I have different folder names inside the 3 images so it is just added weight but not overridden.

@rhuss rhuss closed this Feb 23, 2015
@jgangemi
Copy link
Collaborator Author

this was closed w/o a merge - was that correct? re-opening for now...

@jgangemi jgangemi reopened this Feb 23, 2015
@rhuss
Copy link
Collaborator

rhuss commented Feb 23, 2015

ah, yes. sorry.

@rhuss rhuss merged commit aad854a into fabric8io:integration Feb 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jgangemi @kuhnroyal @rhuss