Be more robust when parsing Docker auth config #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Especially when there is no auth set, don't barf but simply don't use any auth. Fixes fabric8io#731
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
=========================================
Coverage 47.92% 47.92%
Complexity 1043 1043
=========================================
Files 130 130
Lines 6714 6714
Branches 872 872
=========================================
Hits 3218 3218
Misses 3222 3222
Partials 274 274
Continue to review full report at Codecov.
|
|
[merge] |
rgbj
pushed a commit
to rgbj/docker-maven-plugin
that referenced
this pull request
Jun 21, 2017
PR merged! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially when there is no auth set, don't barf but simply don't
use any auth.
Fixes #731