Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves issue 207 #225

Closed
wants to merge 2 commits into from
Closed

Conversation

jgangemi
Copy link
Collaborator

  • allow 'build' and/or 'run' configuration to be skipped during build
  • fixed model classes to only return first 12 of container id

Signed-off-by: Jae Gangemi jgangemi@gmail.com

jgangemi added 2 commits July 18, 2015 14:28
- fixed model classes to only return first 12 of container id

Signed-off-by: Jae Gangemi <jgangemi@gmail.com>
- fixed model classes to only return first 12 of container id

Signed-off-by: Jae Gangemi <jgangemi@gmail.com>
@rhuss
Copy link
Collaborator

rhuss commented Jul 21, 2015

I wonder whether it wouldn't be better to have a <skip> configuration on both <run> and <build>. This would be closer to the corresponding feature and feels more natural IMO (also it provides more decoupling between build and run). The global config section is more for generic aspects which is valid in general for the image (like the name).

What do you think ?

@jgangemi
Copy link
Collaborator Author

well - there is already the global skip which skips execution of the entire plugin, so i guess this falls inline there...

i'm indifferent - if you think it should be on the build and run configurations, i can move it. i based this on the discussion in #207 which had this being in the 'global' image section.

@rhuss
Copy link
Collaborator

rhuss commented Jul 21, 2015

Yeah, I'm just brainstorming. I know, I suggested a mode but somehow <skip> feels more natural. It also wouldn't interfere with the global skip and we would have nice consistent configuration syntax for skipping stuff on different levels.

So I opt for having a skip on <run> and <build> if you don't mind.

@jgangemi
Copy link
Collaborator Author

ok - i'll take care of it.

@rhuss
Copy link
Collaborator

rhuss commented Jul 21, 2015

Thanks !

@jgangemi
Copy link
Collaborator Author

closing in favor of a new request w/ squashed commits

@jgangemi jgangemi closed this Jul 22, 2015
@jgangemi jgangemi mentioned this pull request Jul 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants