-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to yarn #1130
Move to yarn #1130
Conversation
Super fast, thank you! 🏎 🏎 🏎 |
Should the yarn package be added as paket dependency? The build is currently failing on Windows with:
|
yarn is recommanded to be installed globally on your system. So it's a manual action. After yarn is also distributed via npm so we could cheat but i know no one going this way. |
I think I so something about installing yarn via fake I will take a look |
@MangelMaxime yarn is already installed globally, but that's not what the error is about, it seems to be missing a package in the packages folder. |
I don't understand is why you have yarn under your packages folder. Because for me your error is it's doesn't find the file |
@MangelMaxime That's the first thing I did, it doesn't help. I also tried on two different machines. Yes, looks like Fake is looking for |
My guess is the FAKE helper first checks if Yarn is installed globally and then tries the It'd be good to have Yarn downloaded locally so it's a global requirement less, but I'm not sure how to do it. Apparently this FAKE PR just tries to locate yarn as if it were the Nuget npm package but that doesn't look quite right. |
@ncave The FAKE PR checks the path first, I guess this is how it's located in AppVeyor. Do you have https://github.com/fsharp/FAKE/pull/1494/files#diff-b7934a24ef87f312fdb430e3e0355861R12 |
@alfonsogarciacaro No, I had it installed globally through npm. I'll install it with the windows installer, thanks for the help. |
Works now. Thanks for the help, @MangelMaxime and @alfonsogarciacaro, the problem was located between the keyboard and the chair. |
Nice if you got it working :) For AppVeyor, if it detect a yarn.lock at the root of the project it will install yarn. |
I tested the CI with my fork and they passed: