Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple Trigger Command: validation #57

Closed
fabioformosa opened this issue Jan 11, 2022 · 1 comment
Closed

Simple Trigger Command: validation #57

fabioformosa opened this issue Jan 11, 2022 · 1 comment
Assignees
@fabioformosa
Labels
dev task high priority task
Milestone
v4.0.0 - Fully-Fl...

Comments

@fabioformosa
Copy link
Owner

As a developer,
I want to apply validations on the Simple Trigger Command
So the API can refuse invalid inputs
@fabioformosa fabioformosa self-assigned this Jan 11, 2022
fabioformosa added a commit that referenced this issue Oct 27, 2022
@fabioformosa
#57 #62 added an integration test to check the mandatory fields in sc…
f411659 
…heduling a simple trigger
fabioformosa added a commit that referenced this issue Oct 27, 2022
@fabioformosa
#57 #62 fixed an integration tests
69b6203
@fabioformosa
Copy link
Owner Author

fabioformosa commented Oct 27, 2022 •
edited
Loading

Simple Trigger

  • Mandatory fields: jobclass, triggerName

  • dates: endDate cannot be before the startDate

  • positive numbers: repeatInterval cannot be negative

  • relations: if repeatCount and repeatInterval must be both set or unset

  • frontend side

fabioformosa added a commit that referenced this issue Oct 27, 2022
@fabioformosa
#57 added validation checks onto the SimpleTrigger
33b4d88
fabioformosa added a commit that referenced this issue Oct 29, 2022
@fabioformosa
#57 improved some oas captions
d9ff379
fabioformosa added a commit that referenced this issue Oct 29, 2022
@fabioformosa
#57 added new validation checks to the simple trigger input
b968329
fabioformosa added a commit that referenced this issue Nov 2, 2022
@fabioformosa
#57 converted template-driven form in reactive form
121f2e3
fabioformosa added a commit that referenced this issue Nov 3, 2022
@fabioformosa
#57 fixed tests
a8fb990
fabioformosa added a commit that referenced this issue Nov 3, 2022
@fabioformosa
#57 fixed tests
d164cb9
fabioformosa added a commit that referenced this issue Nov 3, 2022
@fabioformosa
#57 added an error message for required fields
459aa13
fabioformosa added a commit that referenced this issue Nov 3, 2022
@fabioformosa
#57 fixed a test
3e90a9b
fabioformosa added a commit that referenced this issue Nov 3, 2022
@fabioformosa
#57 temporary disabled a flaky assertion
1207a64
fabioformosa added a commit that referenced this issue Nov 4, 2022
@fabioformosa
#57 attempt to solve the flaky test
026bdc6
fabioformosa added a commit that referenced this issue Nov 5, 2022
@fabioformosa
#57 clean up
1b1be18
fabioformosa added a commit that referenced this issue Nov 5, 2022
@fabioformosa
#57 attempt to fix the flaky tests
f4dd851
fabioformosa added a commit that referenced this issue Nov 5, 2022
@fabioformosa
#57 attempt to fix the flaky tests
9b32f5e
fabioformosa added a commit that referenced this issue Nov 5, 2022
@fabioformosa
#57 attempt to fix the flaky tests
9ea4afc
fabioformosa added a commit that referenced this issue Nov 5, 2022
@fabioformosa
#57 attempt to fix the flaky tests
a44d041
fabioformosa added a commit that referenced this issue Nov 5, 2022
@fabioformosa
#57 added custom validations to the trigger form
014c348
fabioformosa added a commit that referenced this issue Nov 5, 2022
@fabioformosa
#57 enhanced the layout of the trigger form
85ba371
fabioformosa added a commit that referenced this issue Nov 5, 2022
@fabioformosa
#57 enhanced the layout of the trigger form
12f91fa
fabioformosa added a commit that referenced this issue Nov 5, 2022
@fabioformosa
#57 fixed tests
3242457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabioformosa fabioformosa

Labels
dev task high priority task
Projects
None yet
Milestone
v4.0.0 - Fully-Fledged Management of ...
Development

No branches or pull requests
1 participant
@fabioformosa