-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Web API template support #198
base: master
Are you sure you want to change the base?
Conversation
Anyone review this? |
Currently developers use their own structure / architecture when developing APPs or APIs using the ExpressJS this might leading to bit confusing for other developers when working on someone else developed APPs. It would be great if you can come up with a new boilerplate for both APPs and APIs separately or together. I have raised this question on Stackoverflow (NODEJS Express application generator for API) and one of its answer directed me to this thread. This will help to stick in one path for the whole community together. TIA. |
Hey Everyone! Sorry that this has sat with no response for so long. I will take a look this weekend, but I see no reason this at the surface that this should be turned down. That said, I have been working a bit behind the scenes to build a new generator for the project which will hopefully replace this. There are many reasons which I have not well documented, and some of which might be contentious, but I promise I will document them. This re-write is one of the reasons I have not prioritized following up on these issue (which I think was a mistake). If anyone else wants to help with the process of triaging and getting these lined up for a release on this major version line, the help would be greatly appreciated. The best way to get started being involved is to join our Triage team (cc @expressjs/triagers). You can read more about that here: expressjs/express#4055 |
Ultimately I think we just need to get the new generator going and just not land these types of enhancements to this generator at all. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this change fundamentally changes the expectation of what files come out of the generator, but lacks any docs around that. Ideally we can get docs written up in the README or something about what people should expect the --api
option to do.
This is really the only sticking point on this PR and I have been meaning to just write them myself, but once wes started working on the new, better generator I was hoping that would just make thus repo get archived and we just point to that one.
@dougwilson while I do agree that is the priority, I am sad that this basically means that it is unsupported until I have free time to finish the new one. If someone can step up to triage and get these all sorted, I am fine managing a few point and patch releases so that things do not continue to stall like they have been. |
Anyway, there is my long, overdue review :) |
I'm not sure what exactly is unsupported? I am supporting many of the repos like this... in my spare time just like everyone :D |
I have implemented add web api template support option for express generator for quickly create simple web api without view.