-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade @sentry/react-native
#301
Conversation
Would this be breaking because Sentry now expects these fields to be either set or |
I don't think so - I assume the type is stricter than the implementation 🙂 Haven't checked tho. The reason I think this might be breaking is simply because the user's version must match |
Thank you very much for your contribution. I've wrapped these changes into #302, as those are also breaking changes and I'd rather ship a single major release. |
you can land this on a separate branch (then land that in bulk for release) so the commit (and the contribution) is kept in history. I personally don't care (just happy to see movement! 🥳), but I think in general that's a better approach than bundling it all under "eas support" |
You're right, I forget that matters for external contributions. |
Thanks! |
@SimenB If you restore the other 2 branches, I'd be happy to do the same there. |
Done 👍 I'm happy to rebase if needed (I assume they conflict with this PR) (rebased them) |
hah, should have held off on the rebase 😛 |
Checklist
Why
The current version is quite outdated.
Closes #293
How
Upgraded all
@sentry
packages, and made the necessary type change.I'm not sure if this should be considered a breaking change?
Test Plan
Not sure - hopefully you have some test app you can use? 😀