circular-buffer: Overwrite operation is not clear #889
Comments
|
@shaleh Would you be interested in creating a PR to fix this issue? |
|
I can do that.
…On September 7, 2017 2:36:59 AM PDT, Erik Schierboom ***@***.***> wrote:
@shaleh Would you be interested in creating a PR to fix this issue?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#889 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
shaleh
pushed a commit
to shaleh/exercism-problem-specifications
that referenced
this issue
Sep 7, 2017
As discussed in exercism#889, the documentation for the overwrite operation was vague. overwrite replaces the oldest element in the buffer if the buffer is full and is just a normal write if there is space available.
|
PR uploaded |
shaleh
pushed a commit
to shaleh/exercism-problem-specifications
that referenced
this issue
Sep 21, 2017
As discussed in exercism#889, the documentation for the overwrite operation was vague. overwrite replaces the oldest element in the buffer if the buffer is full and is just a normal write if there is space available. Overwrite replaces the oldest item in the buffer if the buffer is empty. Otherwise it is just like write. This commit documents what overwrite on a buffer with available space looks like and clarifies what the oldest element is after an overwrite operation succeeds. Closes exercism#889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text says that
The client can opt to overwrite the oldest data with a forced write.What it does not say is that this is only expected to happen when the buffer is full. The example shows this but the description does not make it clear. Basically overwrite is just write unless the buffer is full.The text was updated successfully, but these errors were encountered: