Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exercise sublist #322

Merged
merged 1 commit into from
Jul 18, 2017
Merged

Add exercise sublist #322

merged 1 commit into from
Jul 18, 2017

Conversation

matthewmorgan
Copy link
Contributor

@matthewmorgan matthewmorgan commented Jul 16, 2017

@exercism/ecmascripts ?

@rchavarria @joelwallis I did solve this one. This solution was built entirely using TDD, with a refactor at the end to use an object instead of if statements. 😜

@matthewmorgan matthewmorgan force-pushed the add-exercise-sublist branch 2 times, most recently from 4227c7c to 4a1071e Compare July 16, 2017 02:04
@rchavarria
Copy link
Contributor

Congrats!! It looks really nice and clean. From my side, it's ready to be merged, but I'd prefer mergin #321 (and probably #323) and that would create some conflicts in this MR.

What do you think, @matthewmorgan ?

@rchavarria
Copy link
Contributor

As #323 adds a README for each exercise, I think this PR should include one for the sublist exercise. Would you mind to include it, please?

@matthewmorgan
Copy link
Contributor Author

@rchavarria I wouldn't mind merging the other PRs first, and adding the README is no problem. I am a little concerned about merging #321 without modifying it to classify exercises as Katrina mentioned in the PR. Can we merge that and do the classifying etc later? Otherwise that's a lot of work all at once.

@rchavarria
Copy link
Contributor

I hope so, I hope we can merge #321 and then work on config.json later. I don't know about a deadline.

In fact, I already merge a similar PR for the JavaScript track. I plan to work on the JavaScript track adding topics and selecting some core exercises. But I can't say how long it will take. I think I will give this task more priority than fixing ESLint errors for this track. Then, when the JavaScript track is more or less complete, we can transfer most of the work to this one.

@matthewmorgan matthewmorgan force-pushed the add-exercise-sublist branch 2 times, most recently from 628c200 to b6c6d36 Compare July 17, 2017 17:10
@matthewmorgan
Copy link
Contributor Author

OK @rchavarria I merged those other two PRs, added the README (some sections weren't relevant, OK to omit them?) and rebased.

Please let me know if you think there are any other changes needed. Thanks!

@matthewmorgan matthewmorgan force-pushed the add-exercise-sublist branch from b6c6d36 to 6c4de9d Compare July 17, 2017 17:14
@rchavarria
Copy link
Contributor

Simply... awesome!, great work!

@rchavarria rchavarria merged commit 000fd86 into master Jul 18, 2017
@rchavarria rchavarria deleted the add-exercise-sublist branch July 18, 2017 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants