Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add house exercise #297

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Add house exercise #297

merged 1 commit into from
Feb 24, 2025

Conversation

keiravillekode
Copy link
Contributor

No description provided.

@BNAndras BNAndras added x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation labels Feb 23, 2025
{
string expected =
"This is the house that Jack built.";
assert(recite(1, 1) == expected);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recite(1, 1) == expected or expected == recite(1, 1)? This track uses both interchangeably in my experience, but it'd be nice to standardize one way or the other. I don't have a preference one way or the other.

@keiravillekode
Copy link
Contributor Author

The disposable Python I have been using to generate tests has used

== expected

or

 == {expectation}

I'll tidy it a little and add a link here.

Hopefully I looked over the existing tests when I first wrote that, and went with what was common.

@keiravillekode keiravillekode merged commit 208585e into exercism:main Feb 24, 2025
8 checks passed
@keiravillekode keiravillekode deleted the house branch February 24, 2025 05:42
@BNAndras
Copy link
Member

Okay, at some point in the next few days, I’ll make a pass through the existing problems and standardize which side the expected value is on.

@keiravillekode
Copy link
Contributor Author

#298 bin/generate.py generates a reasonable approximation of some test files. I used it to generate tests for exercises I added. (Sometimes I then edited the output.)

I have problem-specifications in a sibling directory of my d checkout.

If starting a new track, with a generator from the start, I would arrange it more like
https://github.com/exercism/arm64-assembly/tree/main/generators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants