Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace 'Contents' with 'On this page' #293

Closed
wants to merge 1 commit into from

Conversation

svenkreiss
Copy link

Fixes #290.

@welcome
Copy link

welcome bot commented Feb 27, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

@choldgraf
Copy link
Member

Hmmm I think that rather than changing this (which would also change it for everybody else), I’d recommend making this configurable. We could add a config value to the theme options that would override the default title for the the within page toc. Then you could override as you wish. Want to give that a shot?

@chrisjsewell
Copy link
Member

chrisjsewell commented Feb 28, 2021

I would point out that we literally already changed this in the opposite direction lol: #145

so yeh this change is a no go, but making it configurable is fine 👍

@svenkreiss
Copy link
Author

I wasn't aware of #145. Obviously I disagree with the outcome of that discussion :)

@choldgraf
Copy link
Member

OK - I opened up #297 to track making this configurable, so going to close this PR. Thanks @svenkreiss for bringing it up!

@choldgraf choldgraf closed this Mar 1, 2021
@choldgraf choldgraf mentioned this pull request Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single content option
3 participants