fix(cli) rollback fees auto calculation #1467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GAtom22
requested review from
Vvaradinov,
MalteHerrmann,
austinchandra and
facs95
and removed request for
a team
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1467 +/- ##
==========================================
- Coverage 73.09% 73.07% -0.02%
==========================================
Files 268 268
Lines 18457 18443 -14
==========================================
- Hits 13491 13478 -13
- Misses 4364 4365 +1
+ Partials 602 600 -2
|
facs95
approved these changes
Mar 14, 2023
MalteHerrmann
added a commit
that referenced
this pull request
Mar 15, 2023
* fix (tests): fix version assertion to be valid for release candidates (#1461) fix unit test assertion for release candidates * fix(evm): add gas used (#1466) * fix(evm): add gas used * add changelog entry * add changelog entry * add changelog entry * Add TxFeeChecker requirement (#1468) * add TxFeeChecker requirement * add unit tests * update Changelog * fix(cli) rollback fees auto calculation (#1467) * chore (ci): update CI workflows to use go v1.20 (#1469) * update CI workflows to use Go 1.20 * update Dockerfile to use Go 1.20 * address linter * fix (ci): fix used Go version in CI by passing version as a string (#1471) fix used Go version in CI by passing version as a string * chore (ci): remove python from CodeQL action (#1472) remove python from CodeQL action * imp(ante): error message (#1470) * imp(ante): error message * add changelog entry * update err msg * update err msg to be general for all clients --------- Co-authored-by: Freddy Caceres <facs95@gmail.com> Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * deps: update cosmos-sdk version (#1473) * deps: update cosmos-sdk version * add changelog entry --------- Co-authored-by: MalteHerrmann <42640438+MalteHerrmann@users.noreply.github.com> * update changelog for rc2 * update upgrade constants for rc2 --------- Co-authored-by: Tom <54514587+GAtom22@users.noreply.github.com> Co-authored-by: Freddy Caceres <facs95@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rollback changes related to the fees
autoflag logic.Note
Some e2e tests are failing because these are done against main branch, which still has the changes related to the fees auto calculation.
Closes #XXX