imp(vesting): add convert vesting account msg #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ENG-1279 Convert Vesting Account
Problem One of the issues with vesting accounts is that when the tokens are fully vested, the account will still have to pay higher tx fees because every time the account will need to check if the tokens are vested. Scope of Work
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1400 +/- ##
==========================================
- Coverage 72.42% 72.40% -0.03%
==========================================
Files 260 260
Lines 17684 17725 +41
==========================================
+ Hits 12807 12833 +26
- Misses 4308 4322 +14
- Partials 569 570 +1
|
fedekunze
reviewed
Feb 16, 2023
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
…om/evmos/evmos into Vvaradinov/convert-vesting-account
Vvaradinov
requested review from
austinchandra
and removed request for
a team
fedekunze
requested changes
Feb 16, 2023
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
…om/evmos/evmos into Vvaradinov/convert-vesting-account # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
fedekunze
approved these changes
Feb 16, 2023
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
…om/evmos/evmos into Vvaradinov/convert-vesting-account
fedekunze
requested changes
Feb 16, 2023
There was a problem hiding this comment.
sorry @Vvaradinov, I just noticed that we forgot to add a test case for locked tokens
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
…om/evmos/evmos into Vvaradinov/convert-vesting-account # Conflicts:
GAtom22
reviewed
Feb 16, 2023
Co-authored-by: Tomas Guerra <54514587+GAtom22@users.noreply.github.com>
Co-authored-by: Federico Kunze Küllmer <31522760+fedekunze@users.noreply.github.com>
…om/evmos/evmos into Vvaradinov/convert-vesting-account
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a
ConvertVestingAccountmsg which converts a vesting account to a regularBaseAccountonce it has confirmed that no vesting coins are left.Closes ENG-1279