Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to canonical names #16

Closed
mattjohnsonpint opened this issue May 19, 2017 · 4 comments
Closed

Update to canonical names #16

mattjohnsonpint opened this issue May 19, 2017 · 4 comments

Comments

@mattjohnsonpint
Copy link

One of my users pointed out that my library is returning Asia/Rangoon instead of Asia/Yangon for locations in Myanmar. mattjohnsonpint/GeoTimeZone#28

This appears to stem from the data in the timezones.json file here.

Could you please check that the time zone ids are all canoncialized to the current Zone entries instead of Link entries?

Thanks.

@evansiroky
Copy link
Owner

Will do. Thanks for bringing this to my attention. So basically I should refactor any zone that appears in the 3rd column of the backward file of the timezone database, right?

@mattjohnsonpint
Copy link
Author

Really, just any Link entry, regardless of which file its found in. There are several links that are in the region files.

Sure, any consumer could resolve the link themselves, so it's not super critical - but there's no reason not to give the canonical Zone name.

@evansiroky
Copy link
Owner

evansiroky commented May 29, 2017

Hmm, I looked at this a bit further and you're right that there are a bunch of links in the regions files.
Since the timezone database tries to have a zone for each nation-state I'm kind of leaning toward keeping those linked zone names in this project.

The backward zones I'll definitely fix tho. Here's a running list of my progress on refactoring them.

  • America/Atikokan
  • America/Coral_Harbour
  • America/Montreal
  • America/Toronto
  • Asia/Chongqing
  • Asia/Harbin
  • Asia/Kashgar
  • Asia/Rangoon
  • Asia/Shanghai
  • Asia/Urumqi
  • Asia/Yangon
  • Pacific/Chuuk
  • Pacific/Honolulu
  • Pacific/Johnston
  • Pacific/Yap

@mattjohnsonpint
Copy link
Author

Sure. If the only entry for a given nation-state is a link to a zone that is in a different nation-state, then use the link. Otherwise, use the zone. That makes sense.

pirxpilot added a commit to pirxpilot/tz-lookup that referenced this issue Jan 24, 2018
America/Coral_Harbour now integrated into America/Atikokan
America/Montreal now integrated into America/Toronto

see: evansiroky/timezone-boundary-builder#16
pirxpilot added a commit to pirxpilot/tz-lookup that referenced this issue Jan 25, 2018
America/Coral_Harbour now integrated into America/Atikokan
America/Montreal now integrated into America/Toronto

see: evansiroky/timezone-boundary-builder#16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants