-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to canonical names #16
Comments
Will do. Thanks for bringing this to my attention. So basically I should refactor any zone that appears in the 3rd column of the backward file of the timezone database, right? |
Really, just any Sure, any consumer could resolve the link themselves, so it's not super critical - but there's no reason not to give the canonical |
Hmm, I looked at this a bit further and you're right that there are a bunch of links in the regions files. The backward zones I'll definitely fix tho. Here's a running list of my progress on refactoring them.
|
Sure. If the only entry for a given nation-state is a link to a zone that is in a different nation-state, then use the link. Otherwise, use the zone. That makes sense. |
America/Coral_Harbour now integrated into America/Atikokan America/Montreal now integrated into America/Toronto see: evansiroky/timezone-boundary-builder#16
America/Coral_Harbour now integrated into America/Atikokan America/Montreal now integrated into America/Toronto see: evansiroky/timezone-boundary-builder#16
One of my users pointed out that my library is returning
Asia/Rangoon
instead ofAsia/Yangon
for locations in Myanmar. mattjohnsonpint/GeoTimeZone#28This appears to stem from the data in the
timezones.json
file here.Could you please check that the time zone ids are all canoncialized to the current
Zone
entries instead ofLink
entries?Thanks.
The text was updated successfully, but these errors were encountered: