chore: Fix clippy warnings #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Vectors` This is a clippy recommendation. `unwrap_or()` was previously used, because specifying Vector's generic type might have been needed.
This file is generated by `flatc` based on the provided schema, so editing it directly, besides just adding a ignore statement, is undesired. We are already ignoring a warning about unused imports within that file.
`zstd::bulk::decompress` actually does not require data to be a mutable borrow, so we might as well not give it one.
This constructor was never used and didn't even need to exist. Clippy was also complaining that the function had too many arguments.
ev3nvy
added
type: chore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes clippy warnings generated by the default settings of clippy. Before stable release, I plan to enable more rules, but this is fine for now, as I don't wanna spend time fixing those now.