chore: remove schema compilation from build process #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes schema compilation, but instead uses a schema from the releases section over at `rman-schema`. Submodule `rman-schema` is no longer being used, however it will stay linked and updated as a way to track which version of the schema is being used.
ev3nvy
added
type: chore
Once `format_generated_files` is stabilised we can use that instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the build process so that it no longer compiles the flatbuffers schema using the build script. Instead, we now just have the compiled schema inside of src/generated folder. This closes #31 because we no longer have to ship
flatcalongside out project.Motivation
This way we don't need to ship flatc with the project.