refactor: Conform to api guidelines #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some structs were missing `Copy` implementations.
Specifically to "The error message given by the Display representation of an error type should be lowercase without trailing punctuation, and typically concise."
Although this doesn't seem as broadly adapted, seems like a good idea, because I do agree with "Like it or not, example code is often copied verbatim by users. Unwrapping an error should be a conscious decision that the user needs to make."
ev3nvy
added
status: completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes various changes for the project to conform to rust's API guidelines.
None of these changes are breaking changes.