feat: Add optional serialization and deserialization with serde #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serde `Serialize` and `Deserialize` derives will be locked behind a serde feature, because this might be functionality that not everyone needs and will not be enabled by default.
ev3nvy
added
type: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds serde as an optional dependency for serializing and de-serializing various structs.
Because this is a non-essential feature, it has to be explicitly enabled with the new
serdefeature (disabled by default).Currently, some structs do not derive
DeserializeandSerialize, because I don't deem it necessary. If it comes up in a future discussion with a valid use case, we will add them then.