refactor: Add dependency byteorder #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the entire Cursor class along with the structs directory, replaces the previous read methods with the ones from byteorder and removes now excessive error classes.
ev3nvy
force-pushed
the
add-dependency-byteorder
branch
from
7345ca4 to
01d0d10
Compare
ev3nvy
added
dependencies
ev3nvy
added
type: refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the custom Cursor class and replaces it with methods provided by byteorder.
This was done because the little amount of reading we do ourselves is so small that having an entire custom class to do it was excessive. Another reason is to not reinvent the wheel. :^)
Because all of the reading is now handled by
byteorder, error class was also simplified by removingCursorErrorandReadError, as they would now be excessive and throwing correct errors would introduce a lot of boilerplate code everywhere.Further optimization to be done is to use
BufReaderwherever possible.