test: Add unit tests #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ev3nvy
added
status: in progress
ev3nvy
force-pushed
the
add-unit-tests
branch
3 times, most recently
from
9cb78c6 to
3007ed5
Compare
ev3nvy
force-pushed
the
add-unit-tests
branch
from
3007ed5 to
fc63831
Compare
Added tests that check: - if valid headers do indeed parse sucessfully, - if correct values are stored into the FileHeader struct, - if correct error is thrown when file ends unexprectedly, - that the header data is not completely incorrect.
ev3nvy
force-pushed
the
add-unit-tests
branch
from
fc63831 to
b7f0c4a
Compare
This build script generates .manifest files used in tests and doc tests. Currently it generates two files: - `valid.manifest` - this is a pretty minimal valid manifest file, - `valid_empty.manifest` - this is a valid manifest file with empty vectors. Building more manifests may be added once/if I think of additional different cases we should test.
|
This seems fine for now tbh. More tests will be added as issues arise. |
ev3nvy
added
status: completed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for
FileHeaderandManifestFile. It also adds a build script, which can build manifest files. Those are then used in unit tests, and will also be able to be used in doc tests.