Improve confusing phrasing #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I find this phrasing ("Under no circumstances User approval [...]") confusing.
It initially seems like a misprint with one sentence suddenly interrupted by the
other, which then becomes "User approval to present data from their Wallet Unit
should be construed as lawful grounds [...]" which appears to be the opposite of
the intended meaning.
skounis
reviewed
Feb 13, 2025
| @@ -2685,7 +2685,7 @@ will be further discussed with Member States for ARF 2.0. | |||
|
|
|||
| **Note: In this document the term 'User approval' exclusively refers to a User's | |||
| *decision to present an attribute to a Relying Party. Under no circumstances | |||
| *User approval to present data from their Wallet Unit should be construed as | |||
| *should User approval to present data from their Wallet Unit be construed as | |||
There was a problem hiding this comment.
The existing phrase is grammatically incorrect. The suggestion does indeed fix it.
skounis
approved these changes
Feb 13, 2025
paolo-de-rosa
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find this phrasing ("Under no circumstances User approval [...]") confusing. It initially seems like a misprint with one sentence suddenly interrupted by the other, which then becomes "User approval to present data from their Wallet Unit should be construed as lawful grounds [...]" which appears to be the opposite of the intended meaning.