Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo and phrasing fixes #187

Merged
merged 15 commits into from
Jun 28, 2024
Merged

Conversation

toonn
Copy link
Contributor

@toonn toonn commented Jun 10, 2024

I kept track of typos and other minor issues while reading through the ARF. I'm not sure these changes are significant enough to warrant their own PRs so I bundled them. I can drop, squash or split commits into separate PRs if desired and am open to input about the semantic changes suggested.

Copy link
Contributor

@pinamiranda pinamiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with all the changes, except deleting "that" in line 1221 (docs/arf.md file)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with all the changes, except deleting "that" in line 1221 (docs/arf.md file)

@skounis skounis added this to the v1.4.1 Service Release milestone Jun 27, 2024
Copy link
Contributor

@skounis skounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we approve we should take care of the @pinamiranda comment

Agree with all the changes, except deleting "that" in line 1221 (docs/arf.md file)

Copy link
Contributor

@skounis skounis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will fix the text after the merge as per

@digeorgi digeorgi merged commit 169537d into eu-digital-identity-wallet:main Jun 28, 2024
skounis pushed a commit that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants