Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/issue 175 brokenannexeslinks #183

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Feat/issue 175 brokenannexeslinks #183

merged 4 commits into from
Jun 28, 2024

Conversation

skounis
Copy link
Contributor

@skounis skounis commented Jun 3, 2024

Resolves #175

pinamiranda
pinamiranda requested changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@pinamiranda pinamiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change in line 207 needs to be reviewed. The link is to "annexes/annex-2/annex_2-high-level-requirements.md" and it should be to "annexes/annex-2/annex-2-high-level-requirements.md"

@skounis
Copy link
Contributor Author

skounis commented Jun 27, 2024 •
edited
Loading

Change in line 207 needs to be reviewed. The link is to "annexes/annex-2/annex_2-high-level-requirements.md" and it should be to "annexes/annex-2/annex-2-high-level-requirements.md"

@pinamiranda Thank you for the attention. I fixed it (28532af) and updated the PR:

pinamiranda
pinamiranda approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@pinamiranda pinamiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree

@digeorgi digeorgi added this to the v1.4.1 Service Release milestone Jun 27, 2024
@skounis skounis requested a review from duviner June 27, 2024 08:10
@digeorgi digeorgi merged commit 20a0eb0 into eu-digital-identity-wallet:main Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinamiranda pinamiranda pinamiranda approved these changes

@duviner duviner duviner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.1 Service Release
Development

Successfully merging this pull request may close these issues.

Fix broken link to the annexes
4 participants
@skounis @pinamiranda @duviner @digeorgi