Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tx refactor clean-up #887

Merged
merged 5 commits into from
Sep 22, 2020
Merged

Tx refactor clean-up #887

merged 5 commits into from
Sep 22, 2020

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Sep 22, 2020

This PR accomplishes a few housekeeping tasks left over from #812:

  • Removes an extra added console.log
  • Adds additional documentation for tx.sign to highlight that only the returned Transaction is signed
  • Re-adds TxOptions to behave more similarly to other packages

@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #887 into master will decrease coverage by 0.12%.
The diff coverage is 91.66%.

Impacted file tree graph

Flag Coverage Δ
#account 92.85% <ø> (ø)
#block 76.65% <75.00%> (-0.17%) ⬇️
#blockchain 80.13% <ø> (-0.32%) ⬇️
#common 93.19% <ø> (ø)
#ethash 82.22% <ø> (-1.12%) ⬇️
#tx 93.08% <100.00%> (+0.13%) ⬆️
#vm 88.16% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit d62d9f2 into master Sep 22, 2020
@holgerd77 holgerd77 deleted the tx-cleanup branch September 22, 2020 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants