Turn off libp2p transport by default #2557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
holgerd77
reviewed
Feb 28, 2023
packages/tx/tx
Outdated
| @@ -0,0 +1 @@ | |||
| ./tx | |||
There was a problem hiding this comment.
You've got some strange thing in here which (likely) leads the (tx) tests to fail.
There was a problem hiding this comment.
Interesting. I must have accidentally committed something else and didn't see it when I was writing the commit message
There was a problem hiding this comment.
OKay, removed the errant commit. Should be good now.
holgerd77
reviewed
Feb 28, 2023
| @@ -38,7 +38,7 @@ | |||
| "clean": "../../config/cli/clean-package.sh", | |||
| "client:start": "ts-node bin/cli.ts", | |||
| "client:start:dev1": "npm run client:start -- --discDns=false --discV4=false --bootnodes", | |||
| "client:start:dev2": "npm run client:start -- --discDns=false --discV4=false --transports=rlpx --port=30304 --dataDir=datadir-dev2", | |||
| "client:start:dev2": "npm run client:start -- --discDns=false --discV4=false --port=30304 --dataDir=datadir-dev2", | |||
There was a problem hiding this comment.
Oh, THAT'S an impressive catch. 🙂 🙃
There was a problem hiding this comment.
Only because I'm pretty sure I originally added that. 😉
acolytec3
force-pushed
the
rlpx-only-please
branch
from
a108fb7 to
0b0441c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the default transport in the client rlpx only for now since libp2p transport is only semi-functional and can lead to hard to debug port conflicts for code that is not currently being used